fix(ghostty): improve Ghostty font detection #1972
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses ghostty +show-config to get effective configuration including sourced config files, with fallback to static config file parsing. This resolves detection failures when configs use config-file directives. Ref: ghostty-org/ghostty@de428d9 Signed-off-by: Yihuang Yu <[email protected]>
|
My ghostty config: Without fix: |
CarterLi
added a commit
that referenced
this pull request
Sep 20, 2025
|
Just remove the old implementation I think. Please test if de92296 works for you. |
Thank you for the fix, that works for me. and remove old detection is nice for maintainence. Let me close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses ghostty +show-config to get effective configuration including sourced config files, with fallback to static config file parsing. This resolves detection failures when configs use config-file directives.
Ref: ghostty-org/ghostty@de428d9